Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add development instructions #114

Merged
merged 6 commits into from
Apr 13, 2024
Merged

README: Add development instructions #114

merged 6 commits into from
Apr 13, 2024

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Apr 12, 2024

Also:

  • Makes the second parameter of deployment-artifacts-to-app-env.ts optional and emit on stdout when missing, so that people can use the script to copy & paste into their env file easily.
  • In the .env example file, make the hardhat env the default (one less thing to do for contributors).

Also:
- Makes the second parameter of deployment-artifacts-to-app-env.ts
  optional and emit on stdout when missing, so that people can use the
  script to copy & paste into their env file easily.
- In the .env example file, make the hardhat env the default (one less
  thing to do for contributors).
@bpierre bpierre marked this pull request as ready for review April 12, 2024 13:36
# NEXT_PUBLIC_CHAIN_CONTRACT_ENS_RESOLVER=0xce01f8eee7E479C928F8919abD53E553a36CeF67|19258213
# NEXT_PUBLIC_CHAIN_CONTRACT_MULTICALL=0xca11bde05977b3631167028862be2a173976ca11|14353601

# Hardhat / Anvil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to add "Anvil". I was thinking it would be confusing that we're running Anvil but only referring to Hardhat in the config.

Copy link
Collaborator

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 👍

@bpierre bpierre merged commit 74a2791 into main Apr 13, 2024
6 checks passed
@bpierre bpierre deleted the dev-instructions branch April 13, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants